Simplified disk builder #313
Closed
+765
−471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasoncouture
force-pushed
the
simplied_disk_builder
branch
from
6354b74 to
53fc5f4
Compare
jasoncouture
force-pushed
the
simplied_disk_builder
branch
from
53fc5f4 to
9148b01
Compare
This adds support for loading a ramdisk/initrd, and an API to add one to the boot image.
Co-authored-by: Philipp Oppermann <[email protected]>
…p, and remove the extra unnecessary variable
Rather than replace range_inclusive, we can remove the nesting doll math from ramdisk_page_count instead. IMO this makes the code a bit more readable.
Co-authored-by: Philipp Oppermann <[email protected]>
Co-authored-by: Philipp Oppermann <[email protected]>
…or the ramdisk path Co-authored-by: Philipp Oppermann <[email protected]>
Merged
jasoncouture
force-pushed
the
simplied_disk_builder
branch
from
9148b01 to
9731b68
Compare
|
Merged into #302 |
|
Going to open a new PR for my other branch for this instead. which is compatible with the current main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part one of addressing issue #299 requires PR #302 first, and incorporates changes from PR #304
Closes #287
Starts at commit: 154dbab